Conversation
Only works when project is installed from built distribution, does not work when running within project directory.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors import paths in the application entrypoints, configures the project layout and dependencies in pyproject.toml (including console scripts and uv-based workflows), updates CI to use uv, and adds a Python version file.
- Switched
logging_configimports tosrc.logging_configin both client and server - Enhanced
pyproject.tomlwith a build-system, dependency groups, console scripts, setuptools packages, and license - Updated GitHub Actions to install and use uv for dependency management and testing
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| server/main.py | Changed logging_config import to use the src package |
| client/main.py | Changed logging_config import to use the src package |
| pyproject.toml | Added build-system, dependency-groups, console scripts, packages, license, and tightened rsa version |
| docs/conf.py | Removed now-obsolete logging_config.py exclude |
| .python-version | Added file to pin Python version to 3.12 |
| .github/workflows/unittests.yml | Updated CI to install uv and run uv sync/uv run pytest steps |
Comments suppressed due to low confidence (3)
pyproject.toml:9
- Typo in the project description: "Sever-Client" should be "Server-Client".
description = "Sever-Client program pair capable of delivering messages between clients"
.github/workflows/unittests.yml:20
- The
Install uvstep runs before setting up Python; you should configure the Python environment first so that uv has a valid interpreter.
- - name: Install uv
pyproject.toml:25
- [nitpick] New console script entry points are defined here; consider adding integration tests to verify these CLI commands are installed and invoke the correct functions.
client = "client:__main__.main"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.